rustdoc: fix a few spots where emit isn't respected#155374
Open
notriddle wants to merge 1 commit intorust-lang:mainfrom
Open
rustdoc: fix a few spots where emit isn't respected#155374notriddle wants to merge 1 commit intorust-lang:mainfrom
notriddle wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
notriddle
commented
Apr 16, 2026
Comment on lines
+193
to
+195
| if !opt.emit.is_empty() && !opt.emit.contains(&EmitType::HtmlStaticFiles) { | ||
| return Ok(()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Alternatively, custom css should be considered non-static for the purpose of the --emit flag. In that case, the custom css emit code would be wrapped in if opt.should_emit_crate() { ... } and the built-in emit code below would be left alone.
Which one should it be?
d8cecac to
0731fa8
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
r? @fmease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155298