BufWriter: Make the soundness of BorrowedBuf usage clearer.#155321
Open
briansmith wants to merge 1 commit intorust-lang:mainfrom
Open
BufWriter: Make the soundness of BorrowedBuf usage clearer.#155321briansmith wants to merge 1 commit intorust-lang:mainfrom
BufWriter: Make the soundness of BorrowedBuf usage clearer.#155321briansmith wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
The previous safety comment was outdated as it was written before `BorrowedBuf::set_init` was changed to be a boolean. It also failed to address the possibility that `flush_buf` invalidated the assumption.
briansmith
force-pushed
the
b/bufwriter-conservative
branch
from
858db5d to
6f35180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous safety comment was outdated as it was written before
BorrowedBuf::set_initwas changed to be a boolean. It also failed to address the possibility thatflush_bufinvalidated the assumption.