Skip to content

DRAFT / WIP: upload source archive before any rustwide tweaking of the crate #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
syphar wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DRAFT / WIP: upload source archive before any rustwide tweaking of the crate #3144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d551d
update rustwide for copy-source
syphar Jan 16, 2026
0defbbe
add
syphar Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 23 additions & 14 deletions crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,23 +621,32 @@ impl RustwideBuilder {
fs::create_dir_all(&self.config.temp_dir)?;
let local_storage = tempfile::tempdir_in(&self.config.temp_dir)?;

let mut algs = HashSet::new();
let (files_list, source_size) = {
debug!("adding sources into database");
let temp_dir = tempfile::tempdir_in(&self.config.temp_dir)?;

krate.copy_source_to(&self.workspace, temp_dir.path())?;

let (files_list, new_alg) = self.runtime.block_on(add_path_into_remote_archive(
&self.storage,
&source_archive_path(name, version),
&temp_dir,
))?;

fs::remove_dir_all(temp_dir.path())?;

algs.insert(new_alg);
let source_size: u64 = files_list.iter().map(|info| info.size).sum();
(files_list, source_size)
};

let successful = build_dir
.build(&self.toolchain, &krate, self.prepare_sandbox(&limits))
.run(|build| {
let mut algs = HashSet::new();

debug!("adding sources into database");
let files_list = {
let (files_list, new_alg) =
self.runtime.block_on(add_path_into_remote_archive(
&self.storage,
&source_archive_path(name, version),
build.host_source_dir(),
))?;
algs.insert(new_alg);
files_list
};
let source_size: u64 = files_list.iter().map(|info| info.size).sum();
// NOTE: rustwide will run `copy_source_to` again when preparing the call to this
// closure.
// This could be optimized, but only with more rustwide changes.
let metadata = Metadata::from_crate_root(build.host_source_dir())?;
let BuildTargets {
default_target,
Expand Down
Loading