[client] Add chain tip query method to getdeploymentinfo RPC
#480
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getdeploymentinfo RPC blockhash argument is optional, if ommited it queries the chain tip. This commit enables such RPC use case.
Collaborator
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
Needs a second call in the existing test to use this new macro. Maybe with an assert that the returned data is for the current chain tip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getdeploymentinfoRPCblockhashargument is optional. If omitted, it queries the blockchain tip. This commit enables such RPC use case.Partially fixes issue #474.