[client] Validate conf_target argument value range in estimaterawfee RPC
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conf_target argument only takes in values from 1 to 1008 inclusive all values outside these ranges are not valid calls. This commit adds validation for it in all versions from v17 to v30 with tests.
| pub fn estimate_raw_fee(&self, conf_target: u32) -> Result<EstimateRawFee> { | ||
| if !(1..=1008).contains(&conf_target) { | ||
| return Err($crate::client_sync::error::Error::Returned( | ||
| "Invalid conf_target, must be between 1 and 1008".to_string(), |
Collaborator
There was a problem hiding this comment.
Suggested change
| "Invalid conf_target, must be between 1 and 1008".to_string(), | |
| "invalid conf_target, must be between 1 and 1008 inclusive".to_string(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conf_targetargument only takes in values from 1 to 1008 inclusive. All values outside these ranges return an error. This commit adds validation for it in all versions from v17 to v30 with tests.Partially fixes issue #474.