[types] Add missing return fields for gettxoutsetinfo RPC
#475
+211
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPC has missing fields which are enabled only when `coinstatsindex` or muhash hash type is used. Argument list is also added to header coment.
natobritto
force-pushed
the
fix-gettxoutsetinfo
branch
from
60cdd1a to
87826eb
Compare
| let disk_size = crate::to_u32(self.disk_size, "disk_size")?; | ||
| let transactions = self | ||
| .transactions | ||
| .map(|v| crate::to_u32(v, "transactions").map_err(E::Numeric)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| .map(|v| crate::to_u32(v, "transactions").map_err(E::Numeric)) | |
| .map(|v| crate::to_u32(v, "transactions") |
Sorry I meant remove all of the map_err(E::Numeric)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC has missing fields which are enabled only when
coinstatsindexoption is called or muhash hash type is used. Argument list is also added to header comment.Partially fixes issue #474.