Skip to content

chore(e2e): add more time for restart test #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Swapnanil-Gupta wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(e2e): add more time for restart test #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1f9f6
e2e: add more time for restart test
Swapnanil-Gupta Feb 10, 2026
c10be97
revert changes to main branch in ci
Swapnanil-Gupta Feb 11, 2026
68d7025
Merge branch 'main' into fix-restart-test
Swapnanil-Gupta Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/finch-vm-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ jobs:
- name: Checkout mainline finch repo
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
# TODO: revert to main
ref: updated-finch-core-nerdctl
repository: runfinch/finch
fetch-depth: 0
persist-credentials: false
Expand All @@ -76,11 +74,8 @@ jobs:
- name: Checkout finch-daemon PR
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
ref: ${{ github.event.pull_request.head.sha || 'main' }}
repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }}
fetch-depth: 0
persist-credentials: false
submodules: recursive
path: finch-daemon-pr

- name: Clean macOS runner workspace
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests/container_restart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func ContainerRestart(opt *option.Option) {
Expect(res.StatusCode).Should(Equal(http.StatusNoContent))
elapsed := later.Sub(now)
Expect(elapsed.Seconds()).Should(BeNumerically(">", 4.0))
Expect(elapsed.Seconds()).Should(BeNumerically("<", 10.0))
Expect(elapsed.Seconds()).Should(BeNumerically("<", 12.0))
containerShouldBeRunning(opt, testContainerName)
})
})
Expand Down
Loading