refactor(webhook): use gateway request context for transformer adapter timeout#6788
Open
akshit-git24 wants to merge 3 commits intorudderlabs:masterfrom
Open
refactor(webhook): use gateway request context for transformer adapter timeout#6788akshit-git24 wants to merge 3 commits intorudderlabs:masterfrom
akshit-git24 wants to merge 3 commits intorudderlabs:masterfrom
Conversation
atzoum
reviewed
Apr 2, 2026
Comment on lines
+324
to
+326
| if len(breq.batchRequest) == 0 { //ensures that we don't process empty batch requests | ||
| continue | ||
| } |
Contributor
There was a problem hiding this comment.
it is never empty
Suggested change
| if len(breq.batchRequest) == 0 { //ensures that we don't process empty batch requests | |
| continue | |
| } |
Contributor
Author
There was a problem hiding this comment.
Hi @atzoum ,
Thanks for the clarity about the batch requests that it would never be empty. Let me remove these line of code and push the changes.
Let me know is there any more advancements needed.
Thank You
1 task
Contributor
Author
|
Hi @atzoum , I've removed the redundant check in my latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @atzoum @mihir20
Description
This PR refactors the existing context in the batchTransformLoop in the webhook.go . Currently there is a TODO : Remove timeout from here after timeout handler is added in gateway. The worker was creating an isolated, hardcoded 10-second timer instead of properly inheriting the master HTTP timeout rules from the original incoming webhook request. . After the changes made in #6751, we can now safely use the original incoming webhook request as same as of gateway.
changes
context.WithTimeoutand the associatedcancel()function calls inbatchTransformLoop.req.request.Context().TODOcomment.Security