Fix #403: exit with error when --gemfile-lock is not a valid lock file#414
Open
kallal79 wants to merge 1 commit intorubysec:masterfrom
Open
Fix #403: exit with error when --gemfile-lock is not a valid lock file#414kallal79 wants to merge 1 commit intorubysec:masterfrom
kallal79 wants to merge 1 commit intorubysec:masterfrom
Conversation
…ock file Bundler::LockfileParser silently accepts any file (Gemfile, README.md, etc.) and returns empty results, causing bundle-audit to exit 0 with 'No vulnerabilities found' even when given the wrong file. Changes: - Add Scanner::InvalidGemfileLock exception class - Add LOCKFILE_HEADER_RE regexp to validate lock file content before parsing - Raise InvalidGemfileLock in Scanner#initialize when file does not start with a recognised Bundler lockfile section header - Rescue InvalidGemfileLock in CLI#check and exit with status 1 plus a descriptive stderr message - Add spec for Scanner#initialize raising InvalidGemfileLock - Add specs for CLI#check printing error to stderr and exiting with 1 Fixes rubysec#403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundler::LockfileParser silently accepts any file (Gemfile, README.md, etc.) and returns empty results, causing bundle-audit to exit 0 with 'No vulnerabilities found' even when given the wrong file.
Changes:
Fixes #403