Open
Conversation
ullet changes: ⏺ The problem: in development, profile_image_link always returns avatar.png (early return on line 23-25) without ever accessing profile.image, so Bullet correctly flags the preloading as unused. But in production the preloading IS needed to avoid N+1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to ruby 3.4
Breaking Changes
local variable in a block will silently change behavior or break.
fiddle are no longer auto-available. You'll get LoadError if they're used without an explicit Gemfile
entry.
'String#foo'). Any test assertions matching exception message strings may fail.
Deprecation Warnings (future breaking changes)
strings will emit deprecation warnings. Run tests with -W:deprecated to surface these.
Removed APIs
Recommended steps
bullet changes: ⏺ The problem: in development, profile_image_link always returns avatar.png (early return on line 23-25) without ever accessing profile.image, so Bullet correctly flags the preloading as unused. But in production the preloading IS needed to avoid N+1.