Skip to content

Resolve Pin Issues - #463

Merged
maneeSHA-256 merged 9 commits into
developmentfrom
maneesha/rbt/resolve-pin-issue
Feb 16, 2026
Merged

maneeSHA-256 merged 9 commits into
developmentfrom
maneesha/rbt/resolve-pin-issue

Conversation

@maneeSHA-256

@maneeSHA-256 maneeSHA-256 commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Issue

This PR is addressing the following issues :

  1. No pins on newly generated local test tokens : there was no pin while first transferring a newly generated token, leading to unpin error logs on sender node
  2. Adding token-state-hash inplace of token-hash to TokenProviderTable of receiver : Receiver was adding token state hash instead of token hash in Provider table. So, when the receiver transfers, it never finds the tokens in Provider table and hence never removes the token details from the table.
  3. Multi-pin check failure : Quorum was fetching the providers list of the token-hash. But while inquiring about the pin role, quorum was passing token-id instead of token-hash. So, when the providers checks its' Provider table it does not get any info, returning false to quorum. Quorum passes multi-pin check due to absence of correct info.

Solution

  1. Token owner is pinning the test tokens while generating them
  2. Receiver is adding token hash to TokenProviderTable. Hence, it is successfully getting removed whenever the token is transferred further.
  3. During multi-pin check, Quorum is inquiring about the token-hash pin role instead of token-id pin role.

…n hash to pin/unpin instead of token id in a few functions
…g token state hash to token provider table of receiver instead of token hash
…n completion confusion on receiver and sender ends
@maneeSHA-256 maneeSHA-256 self-assigned this Feb 11, 2026
@maneeSHA-256
maneeSHA-256 marked this pull request as ready for review February 11, 2026 13:13
@maneeSHA-256 maneeSHA-256 changed the title Maneesha/rbt/resolve pin issue Resolve Pin Issues Feb 13, 2026
@maneeSHA-256
maneeSHA-256 merged commit cd4e995 into development Feb 16, 2026
0 of 3 checks passed
@maneeSHA-256
maneeSHA-256 deleted the maneesha/rbt/resolve-pin-issue branch February 16, 2026 09:51
gklps pushed a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants