Skip to content

fix: add doctype validation in get_doc_events api #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trufurs merged 5 commits into from
Sep 1, 2026
Merged

fix: add doctype validation in get_doc_events api #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b135920
feat: update validation in get_latest_activity, get_doc_events, and u…
zeel-codder Aug 28, 2026
327383b
fix: add doctype validation in get_doc_events api
zeel-codder Aug 28, 2026
c9b59fb
fix: resolve merge conflicts
zeel-codder Sep 1, 2026
e7804d6
fix: resolve merge conflicts
zeel-codder Sep 1, 2026
c3373c4
Merge branch 'version-16-hotfix' into feat/apis
trufurs Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frappe_crm_xt/api/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,12 @@ def get_latest_activity(name: str) -> dict | None:
return None

doctype = _resolve_reference_doctype(name)

if not doctype:
return None

frappe.has_permission(doctype, "read", doc=name, throw=True)

# Cheap pre-flight: query the most-recent single row from each source
# (4 indexed lookups), pick the winner, then fully hydrate ONLY that one.
# Avoids the previous "fetch all notes/tasks + N+1 attachment loads".
Expand Down
7 changes: 7 additions & 0 deletions frappe_crm_xt/api/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ def search_emails(txt: str = ""):
@frappe.whitelist()
def get_doc_events(doctype: str, docname: str | int):
"""Fetch events linked to a document with their participants and notifications."""

if doctype not in ["CRM Deal", "CRM Lead"]:
return []

frappe.has_permission(doctype, "read", doc=docname, throw=True)

event = frappe.qb.DocType("Event")
event_participant = frappe.qb.DocType("Event Participants")

Expand Down Expand Up @@ -80,6 +86,7 @@ def get_doc_events(doctype: str, docname: str | int):

event_names = [e.name for e in events]

# TODO: NEED TO CHECK HOW IT WORKS
participants = frappe.get_all(
"Event Participants",
filters={"parent": ["in", event_names], "parenttype": "Event"},
Expand Down
Loading