Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
crane_x7_moveit_config/launch/demo.launchにはload_robot_descriptionオプションがあります。crane_x7_ros/crane_x7_moveit_config/launch/demo.launch
Line 4 in a214df2
しかし、ここをfalseにした場合でも
use_gazeboがfalseの場合はcrane_x7_control/launch/crane_x7_controlでrobot_descriptionが定義されており、load_robot_descriptionが常にtrueになってしまいます。crane_x7_moveit_config/launch/demo.launch-->crane_x7_moveit_config/launch/move_group.launch-->crane_x7_control/launch/crane_x7_controlの順で呼び出されます。crane_x7_ros/crane_x7_control/launch/crane_x7_control.launch
Lines 5 to 7 in a214df2
これを修正します。
ちなみに
crane_x7_moveit_config/launch/demo.launch-->crane_x7_moveit_config/launch/planning_context.launchはload_robot_descriptionが渡されるようになっています。crane_x7_ros/crane_x7_moveit_config/launch/demo.launch
Lines 31 to 33 in a214df2
crane_x7_ros/crane_x7_moveit_config/launch/planning_context.launch
Line 9 in a214df2
Does this close any currently open issues?
しません
How has this been tested?
Any other comments?
ハードウェアを改造したCRANE-X7実機を動かす際に必要になるオプションなので使われるケースは少ないと思います。
Checklists