Update velodyne_pointcloud CMakeLists.txt export dependencies#553
Open
benjaminholdennearearth wants to merge 2 commits intoros-drivers:ros2from
Open
Update velodyne_pointcloud CMakeLists.txt export dependencies#553benjaminholdennearearth wants to merge 2 commits intoros-drivers:ros2from
benjaminholdennearearth wants to merge 2 commits intoros-drivers:ros2from
Conversation
Ament export requires the dependency names to match the names used in the `find_package` CMake command. Resolves: ros-drivers#550
|
I would upvote that this be merged ASAP as it is required for other packages which build with this one as a dep. Furthermore, I test building this in Jazzy and it needs one more additional related fix to compile, which I mention as a comment in this PR. |
Add missing dependency (yaml-cpp) needed for jazzy build Co-authored-by: Tejas Kumar Shastha <tejas.shastha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ament export requires the dependency names to match the names used in the
find_packageCMake command. Resolves: #550