Skip to content

split sound_play_msgs package#264

Merged
knorth55 merged 4 commits intoros-drivers:ros2from
knorth55:ros2-sound-play-msgs
Feb 17, 2026
Merged

split sound_play_msgs package#264
knorth55 merged 4 commits intoros-drivers:ros2from
knorth55:ros2-sound-play-msgs

Conversation

@knorth55
Copy link
Copy Markdown
Member

@knorth55 knorth55 commented Dec 26, 2025

split sound_play_msgs package from sound_play

Copy link
Copy Markdown

@rkent rkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR its original form with smoke tests of audio_capture, audio_play, and sound_play under humble, jazzy, kilted, and rolling (I have a Docker environment for audio ROS development that makes this easy to do.) Everything worked when compiling the full repository.

However, there are a number of minor issues in the configuration files noted below that should be updated. One example that will fail without these changes is:

colcon build --packages-up-to sound_play

on a fresh workspace. Some of these changes may not be technically necessary, but are intended to follow the examples in ROS 2 documentation.

Overall though this works.

@rkent
Copy link
Copy Markdown

rkent commented Jan 7, 2026

Here's another issue to resolve. You need to add to sound_play/package.xml:

   <exec_depend>ament_index_python</exec_depend>
   <exec_depend>action_msgs</exec_depend>

These are used in libsoundplay.py. Without them, the python documentation generated by rosdoc2 fails.

@knorth55
Copy link
Copy Markdown
Member Author

knorth55 commented Jan 12, 2026

@rkent
Thank you for your review and sorry for update.
I update this PR and follow your feedback!

Could you check this PR again if possible?

@knorth55 knorth55 merged commit 5110728 into ros-drivers:ros2 Feb 17, 2026
17 checks passed
@knorth55 knorth55 deleted the ros2-sound-play-msgs branch February 17, 2026 17:24
@knorth55 knorth55 mentioned this pull request Mar 29, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants