Conversation
Merge develop into branch
semaphoreP
left a comment
There was a problem hiding this comment.
Thanks for finding these fixes. I have one comment below and one suggestion for a unit test:
We could copy test_klipthrupt.test_psfsub_withklipandctmeas_adi() and do it for Band4 WFOV. For the unit tests, we don't care what the data values look like, so we just want to adjust the unit test so the image shape is correct, and modify the header keywords (e.g., after the function runs create_psfsub_dataset(), manually modify some of the header values). Hopefully this is a relatively straightforward adaptation of an existing unit test.
corgidrp/data.py
Outdated
| # Set filter wavelengths | ||
| self.wave_hlc = {'1F': 575e-9} # meters | ||
|
|
||
| self.wave_spc = {'4F': 825e-9} # meters |
There was a problem hiding this comment.
I don't think we need to make these separate dictionaries, as the filter wavelengths won't change with masks. Maybe let's just call it self.filter_wavs rather than self.wave_hlc and put both filters in the same dictionary.
Describe your changes
Type of change
added some option so that WFOV band 4 data can be processed
Reference any relevant issues (don't forget the #)
Checklist before requesting a review
pytestdid not produce any warnings