Skip to content

Stop using auto with * in intuition solver. #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coqbot-app merged 2 commits into from
Oct 9, 2025
Merged

Stop using auto with * in intuition solver. #21129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2648c0
Stop using auto with * in intuition solver.
ppedrot Sep 27, 2025
deaf7ea
Add changelog.
ppedrot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/changelog/04-tactics/21129-intuition-stop-using-auto-with-star-Removed.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- **Removed:**
the implicit call to `auto with *` in intuition solver, that
was deprecated since 8.17
(`#21129 <https://github.com/rocq-prover/rocq/pull/21129>`_,
fixes `#4949 <https://github.com/rocq-prover/rocq/issues/4949>`_,
by Pierre-Marie Pédrot).
4 changes: 1 addition & 3 deletions theories/Corelib/Init/Tauto.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ Local Ltac tauto_gen flags := tauto_intuitionistic flags || tauto_classical flag
Ltac tauto := with_uniform_flags ltac:(fun flags => tauto_gen flags).
Ltac dtauto := with_power_flags ltac:(fun flags => tauto_gen flags).

Ltac intuition_solver :=
first [solve [auto]
| tryif solve [auto with *] then warn_auto_with_star else idtac].
Ltac intuition_solver := auto.

Local Ltac intuition_then tac := with_uniform_flags ltac:(fun flags => intuition_gen flags tac).
Ltac intuition := intuition_then ltac:(idtac;intuition_solver).
Expand Down