fix allocator mismatch in deferred_numeric_literals append#9221
Open
fix allocator mismatch in deferred_numeric_literals append#9221
Conversation
The e_typed_int and e_typed_frac handlers used self.gpa (the checker's worker allocator) instead of self.cir.gpa (the ModuleEnv's allocator) when appending to deferred_numeric_literals. Since the list was initialized with the ModuleEnv allocator, using a different allocator to resize it caused an "Invalid free" panic from the debug allocator's canary check. Also uncomment the guard pattern demo in all_syntax_test.roc which was previously disabled due to this bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Benchmark failure is expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e_typed_int and e_typed_frac handlers used self.gpa (the checker's worker allocator) instead of self.cir.gpa (the ModuleEnv's allocator) when appending to deferred_numeric_literals. Since the list was initialized with the ModuleEnv allocator, using a different allocator to resize it caused an "Invalid free" panic from the debug allocator's canary check.
Also uncomment the guard pattern demo in all_syntax_test.roc which was previously disabled.