Move .. in record to be printed after fields#9217
Open
jaredramirez wants to merge 1 commit intomainfrom
Open
Conversation
jaredramirez
force-pushed
the
jared/push-ysovwqmuvouu
branch
from
6229d66 to
5c38903
Compare
jaredramirez
force-pushed
the
jared/push-ysovwqmuvouu
branch
from
5c38903 to
0d24931
Compare
jaredramirez
force-pushed
the
jared/push-ysovwqmuvouu
branch
from
0d24931 to
1fa4c11
Compare
ayazhafiz
reviewed
Mar 1, 2026
Comment on lines
+594
to
+597
| .unbound => |unbound_var| blk: { | ||
| unbound_ext_occurrences = try self.countVarOccurrences(unbound_var, root_var); | ||
| break :blk unbound_ext_occurrences > 1; | ||
| }, |
Member
There was a problem hiding this comment.
is this safe before generalization?
Collaborator
Author
There was a problem hiding this comment.
yes, i think so, because this codepath is only hit if unifying two variables fail. we convert the vars into bytes for display in the error message, before setting to vars as .errs in the types store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comment from: #9196 (review)
Moves
..to appear at end of record types when printed.Before:
{ .., field: a }After:
{ field: a, ... }Also fixes an error where empty record had extra spaces printed.