Open
Conversation
Add runtime evaluation of `expect` expressions in snippet-type snapshot tests using the existing TestRunner. This catches regressions where expects parse and type-check but fail at runtime. Key details: - Resolve imports before evaluation (interpreter requires explicit resolution) - Use ArenaAllocator for the test runner to avoid roc heap leaks - Skip evaluation when compilation errors exist - Remove `expect c1 != c3` from custom_type_equality test (pre-existing interpreter bug with != on custom opaque types) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use a banner-style format so expect failures stand out in build logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
The test failures below are expected, #9214 needs to be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top level expects in snapshot snippets were not actually run, giving the false impression that they tested something.