Fix build errors with GCC 13 - #3
Open
thburghout wants to merge 1 commit into
Open
Conversation
Author
|
@robseb are you willing to accept these changes? |
samisrana
reviewed
May 16, 2024
|
I see the same problem. It Would be good to merge the proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Building rstools with GCC 13 leads to some fatal errors. I estimate these used to be warning. Most changes are trivial, duplicate
\and missing include header for integer type. The change inFPGA-writeConfig/hps.hwas definitely surprising. I do not understand how this used to work.I hope this patch is useful to you.