Feature/simulation management#6
Draft
Bachibouzouk wants to merge 3 commits intomasterfrom
Draft
Conversation
henhuy
requested changes
Jan 15, 2025
Collaborator
henhuy
left a comment
henhuy
left a comment
There was a problem hiding this comment.
Maybe we should make it somehow save so that others can't delete scenarios easily?
Or we add an option to toggle this on/off and make it off per default?
| hook_type=hooks.HookType.SETUP, scenario=scenario, data=parameters, request=request | ||
| ) | ||
| task = simulation.simulate_scenario.delay(scenario, parameters) | ||
| task = current_app.tasks["django_oemof.simulation.simulate_scenario"].delay(scenario, parameters) |
Collaborator
There was a problem hiding this comment.
Why do you make use of current_app?
Is this a good practice? Did not read about this yet...
Bachibouzouk
force-pushed
the
feature/simulation-management
branch
from
d835da0 to
f42b59f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.