Refactor RzConfig #5820
Refactor RzConfig #5820
Conversation
github-actions
bot
added
rz-bin
RzAnalysis
rz-diff
API
RzCore
visual
panel
RzAsm-Disassembler
RzConfig
Hexagon
labels
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Only checked the main files and hexagon. Looks like a way better architecture now.
Will do a full review later (currently pretty busy).
General request: Please document the high level design somewhere while you still remember the details.
| char *name; ///< Variable name | ||
| char *desc; ///< Description of the variable | ||
| RzList /*<char *>*/ *options; ///< Holds the string options | ||
| ut32 flags; ///< define the type of the data via RzConfigNodeFlags |
There was a problem hiding this comment.
| ut32 flags; ///< define the type of the data via RzConfigNodeFlags | |
| ut32 /*RzConfigNodeFlags*/ flags; ///< define the type of the data. |
|
|
||
| struct rz_config_hold_t { | ||
| RzConfig *cfg; | ||
| RzVector /* ConfigValue */ variables; |
There was a problem hiding this comment.
| RzVector /* ConfigValue */ variables; | |
| RzVector /*<ConfigValue>*/ variables; |
| bool lock; ///< When true forbids the add/remove of variables | ||
| void *user; ///< Pointer passed to the callbacks (getter, setter, setopt) | ||
| RzList /*<RzConfigNode *>*/ *nodes; ///< List of stored variables. | ||
| HtSP *ht; ///< HashMap for fast access to the nodes. |
There was a problem hiding this comment.
| HtSP *ht; ///< HashMap for fast access to the nodes. | |
| HtSP *node_index; ///< HashMap for fast access to the nodes. |
Why not use only a hash map?
There was a problem hiding this comment.
i have remove this (and i'm trying to figure it out where to place this) but essentially is to store the nodes in a sorted way, so when you iterate over them you always have the variables sorted.
There was a problem hiding this comment.
Wouldn't rz_list_add_sorted work?
I mean, does it need to be fast? The configs are no hot path.
| } | ||
|
|
||
| /** | ||
| * \brief Sets the value (type string list) of a given variable of the config |
There was a problem hiding this comment.
| * \brief Sets the value (type string list) of a given variable of the config | |
| * \brief Sets the value (type string list) of a given variable of the config. |
…alysis.vinfun analysis.vinfunrange
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Cleans up RzConfig and implements proper bindings.