-
-
Notifications
You must be signed in to change notification settings - Fork 496
RzMemory for mapped IO interactions. #5805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| #endif | ||
|
|
||
| typedef enum { | ||
| RZ_MEMORY_VISIBILITY_HIDDEN = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hidden means: region is completely covered by another memory region?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
One requirement I would have is for the behavior of reading. It should be configurable. By passing a flag or something. enum {
FIXED_BLOCK, ///< Reads the requested number of bytes. If it reads less than the request number of bytes, the read fails.
UP_TO, ///< Reads up to the number of requested bytes. If it reads less than that, the read still succeeds.
AT_LEAST, ///< The number of requested bytes is the minimum bytes which must be read. Otherwise the read fails.
} RzMemReadBehvior;I am so so annoyed about hour inconsistent and complicated reading behavior. |
|
Also, keep in mind that RzBuffer can't properly handle addresses above |
i forgot about that! |
i can replace the |
|
isn't |
Ah yes, sorry. It was late while writing this. |
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Should replace the whole RzIO layer and most of the RzIO handlers should be translated in RzBuffer equivalents