Skip to content

Conversation

@SSharshunov
Copy link
Contributor

@SSharshunov SSharshunov commented Nov 28, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

...

Test plan

...

Closing issues

ISSUE: Add support for Lua 5.0, 5.1, and 5.2
...

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 50.22048% with 1016 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.70%. Comparing base (d0a0b6e) to head (6c489d2).

Files with missing lines Patch % Lines
librz/bin/format/luac/parse.c 68.33% 75 Missing and 121 partials ⚠️
librz/arch/isa/luac/v55/analysis_55.c 0.00% 140 Missing ⚠️
librz/arch/isa/luac/v51/analysis_51.c 0.00% 113 Missing ⚠️
librz/arch/isa/luac/v52/analysis_52.c 17.32% 102 Missing and 3 partials ⚠️
librz/arch/isa/luac/v51/opcode_51.c 0.00% 83 Missing ⚠️
librz/arch/isa/luac/v55/opcode_55.c 60.89% 3 Missing and 67 partials ⚠️
librz/arch/isa/luac/v51/assembly_51.c 0.00% 61 Missing ⚠️
librz/arch/isa/luac/v51/disassembly_51.c 0.00% 51 Missing ⚠️
librz/bin/p/bin_luac.c 59.64% 20 Missing and 26 partials ⚠️
librz/arch/isa/luac/v52/opcode_52.c 55.68% 4 Missing and 35 partials ⚠️
... and 10 more
Additional details and impacted files
Files with missing lines Coverage Δ
librz/arch/isa/luac/v53/analysis_53.c 19.31% <ø> (ø)
librz/arch/isa/luac/v53/opcode_53.c 59.80% <100.00%> (+1.96%) ⬆️
librz/arch/isa/luac/v54/analysis_54.c 60.00% <ø> (ø)
librz/arch/isa/luac/v54/assembly_54.c 77.86% <100.00%> (+15.47%) ⬆️
librz/arch/isa/luac/v54/disassembly_54.c 91.17% <100.00%> (+4.41%) ⬆️
librz/arch/isa/luac/v54/opcode_54.c 61.14% <ø> (+3.42%) ⬆️
librz/bin/format/luac/luac_common.c 57.31% <ø> (-2.44%) ⬇️
librz/arch/isa/luac/lua_arch.c 80.35% <70.00%> (-4.13%) ⬇️
librz/bin/format/luac/luac_bin.c 72.35% <78.57%> (+2.76%) ⬆️
librz/arch/isa/luac/v53/assembly_53.c 71.08% <76.47%> (+4.41%) ⬆️
... and 17 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a0b6e...6c489d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notxvilka
Copy link
Contributor

Since it's not only 5.2 version, please rename also the PR title.

@SSharshunov SSharshunov changed the title Lua 5.2 support #3914 Lua 5.1-5.5 support and refactoring #3914 Jan 10, 2026
@SSharshunov SSharshunov force-pushed the lua-#3914 branch 9 times, most recently from 1688b5a to c601c1b Compare January 14, 2026 18:19
@SSharshunov SSharshunov force-pushed the lua-#3914 branch 4 times, most recently from a19f317 to a9822b5 Compare January 21, 2026 10:24
@notxvilka notxvilka added this to the 0.9.0 milestone Jan 25, 2026
@SSharshunov SSharshunov force-pushed the lua-#3914 branch 2 times, most recently from 22d27a5 to b669844 Compare January 28, 2026 10:24
Change opcodes

Remove CI warnings

Tests

Tmp

Luac format 5.{1..5}

5.1 and 5.5 analytic and arch

Fix some typos, spdx and refactoring

Parse headers

Asm and disasm

5.2 disasm and asm change bx and ax interpretation

5.3 disasm

5.0 luac format

5.4 asm/disasm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants