[vector-crypto] Clarifying relationship between Zvknhb and Zvknha#2635
[vector-crypto] Clarifying relationship between Zvknhb and Zvknha#2635nibrunieAtSi5 wants to merge 1 commit intoriscv:mainfrom
Conversation
aswaterman
left a comment
There was a problem hiding this comment.
Do normative tags for extension dependence rules really make sense? How could you write a test that tests this property?
I will have to consult @james-ball-qualcomm and the authors of #2518, as I simply reproduced what was done for other extensions in vector-crypto: riscv-isa-manual/normative_rule_defs/vector-crypto.yaml Lines 40 to 48 in b9f1438 |
The current vector crypto specification does not mention any specific link between the two extensions. Their respective description implies that Zvknhb is a subset of Zvknha. This patch attempts at clarifying this relationship as simply as possible.
0afef0b to
b2ed1cc
Compare
|
I think this would be better as a non-normative clarification, because Zvknha is already defined as subset of Zvknhb. The change wouldn't have any effect on the ISA string requirements either... Normative rules should have a meaning. |
The current vector crypto specification does not mention any specific link between the two extensions. Their respective description implies that Zvknhb is a subset of Zvknha. This patch attempts at clarifying this relationship as simply as possible.
I have not modified any of the definition (Zvknhb still defines support for both SEW=32 and 64, and Zvknha defines support for SEW=32, other values being reserved encodings).