Skip to content

Fix some Infer Dead Store warnings #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabio-porcedda wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Fix some Infer Dead Store warnings #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ free_csv_list(list_t *list)
EFI_STATUS
parse_csv_data(char *data, char *data_end, size_t n_columns, list_t *list)
{
EFI_STATUS efi_status = EFI_OUT_OF_RESOURCES;
EFI_STATUS efi_status;
char delims[] = "\r\n";
char *line = data;
size_t max = 0;
Expand Down
2 changes: 1 addition & 1 deletion fallback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static EFI_STATUS
FindSubDevicePath(EFI_DEVICE_PATH *In, UINT8 Type, UINT8 SubType,
EFI_DEVICE_PATH **Out)
{
EFI_DEVICE_PATH *dp = In;
EFI_DEVICE_PATH *dp;
if (!In || !Out)
return EFI_INVALID_PARAMETER;

Expand Down
3 changes: 1 addition & 2 deletions post-process-pe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ load_pe(const char *const file, void *const data, const size_t datasize,
PE_COFF_LOADER_IMAGE_CONTEXT *ctx)
{
EFI_IMAGE_DOS_HEADER *DOSHdr = data;
EFI_IMAGE_OPTIONAL_HEADER_UNION *PEHdr = data;
EFI_IMAGE_OPTIONAL_HEADER_UNION *PEHdr;
size_t HeaderWithoutDataDir, SectionHeaderOffset, OptHeaderSize;
size_t FileAlignment = 0;
size_t sz0 = 0, sz1 = 0;
Expand Down Expand Up @@ -390,7 +390,6 @@ validate_nx_compat(PE_COFF_LOADER_IMAGE_CONTEXT *ctx)
ret = -1;
}

Section = ctx->FirstSection;
for (i=0, Section = ctx->FirstSection; i < ctx->NumberOfSections; i++, Section++) {
debug(NOISE, "Section %d has WRITE=%d and EXECUTE=%d\n", i,
(Section->Characteristics & EFI_IMAGE_SCN_MEM_WRITE) ? 1 : 0,
Expand Down