Save the debug and error logs in mok-variables#726
Conversation
30daae0 to
575fbc5
Compare
|
The result here is you get something like: |
575fbc5 to
d42eccc
Compare
561c613 to
7913f64
Compare
This fixes some minor errors with the testing of how ALIGN() and similar are defined, and makes an explicit "ALIGN_UP()" macro to complement the existing ALIGN_DOWN() macro. Signed-off-by: Peter Jones <pjones@redhat.com>
This moves decls for errlog.c into errlog.h Signed-off-by: Peter Jones <pjones@redhat.com>
de48793 to
d1eb01e
Compare
jsetje
left a comment
There was a problem hiding this comment.
I would change 4096 on line 149 of errlog.c to PAGE_SIZE, even if it will probably always be 4k. Otherwise this looks.
This changes our debug and error logging to save the entire logs into mok-variables as "shim-dbg.txt" and "shim-log.txt". Signed-off-by: Peter Jones <pjones@redhat.com>
Previously when there were no load options, this would go in the debug log: load-options.c:313:parse_load_options() full load options: include/hexdump.h:92:vhexdumpf() hexdump of a NULL pointer! This changes it to say: load-options.c:315:parse_load_options() LoadOptions is empty Signed-off-by: Peter Jones <pjones@redhat.com>
d1eb01e to
0e24f88
Compare
This changes our debug and error logging to save the entire logs into mok-variables as "shim-dbg.txt" and "shim-log.txt".