ci: add workflow to check lib-sync#1230
Open
klaskosk wants to merge 2 commits intorh-ecosystem-edge:mainfrom
Open
ci: add workflow to check lib-sync#1230klaskosk wants to merge 2 commits intorh-ecosystem-edge:mainfrom
klaskosk wants to merge 2 commits intorh-ecosystem-edge:mainfrom
Conversation
It is possible for the sync-libs automation to break if changes are made to sync configs or schemes that have not been verified to work with automation. This commit introduces a new workflow that runs specifically on PRs updating these paths and ensures that running `make lib-sync` against the PR does not introduce any errors. Assisted-by: Cursor
📝 WalkthroughWalkthroughAdds a GitHub Actions workflow that verifies lib-sync is up to date on pull requests to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
072f0b0 to
e0c7e27
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/sync-checker.yml:
- Around line 5-7: The branches filter is using a regex-like string
'release-\d.\d\d' which GitHub Actions does not support; update the branches
array entry to a glob pattern such as 'release-[0-9].[0-9][0-9]' (or another
appropriate glob like 'release-*' if broader matching is acceptable) so the
workflow will trigger for release branches; modify the branches list entry that
currently contains 'release-\d.\d\d' to the chosen glob pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for the sync-libs automation to break if changes are made to sync configs or schemes that have not been verified to work with automation. This commit introduces a new workflow that runs specifically on PRs updating these paths and ensures that running
make lib-syncagainst the PR does not introduce any errors.Assisted-by: Cursor
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.