Draft
Fix: Shift+Wheel scrolls horizontally instead of vertically#838
Conversation
Some browsers (e.g. Yandex on Windows 11) send WheelEvents with deltaY set but deltaX=0 when Shift is held, expecting the app to handle the horizontal scroll conversion. This caused RevoGrid to scroll vertically instead of horizontally. - Add shiftKey to LocalScrollEvent type - Skip vertical scroll in onVerticalMouseWheel when shiftKey is held - Use deltaY as horizontal delta in onHorizontalMouseWheel when shiftKey is held and deltaX is 0 - Add e2e tests for Shift+Wheel and normal wheel scroll behavior Agent-Logs-Url: https://github.com/revolist/revogrid/sessions/8669f3a8-d02f-4b90-a20d-b322c826019f Co-authored-by: m2a2x <6465130+m2a2x@users.noreply.github.com>
Agent-Logs-Url: https://github.com/revolist/revogrid/sessions/8669f3a8-d02f-4b90-a20d-b322c826019f Co-authored-by: m2a2x <6465130+m2a2x@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Fix horizontal scrolling issue with Shift + Wheel in Yandex Browser
Fix: Shift+Wheel scrolls horizontally instead of vertically
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Some browsers (e.g. Yandex on Windows 11) dispatch
WheelEventwithdeltaY/shiftKey=trueanddeltaX=0for Shift+Wheel, expecting the app to handle the axis conversion. RevoGrid was consumingdeltaYvertically and then bailing out of the horizontal handler — resulting in vertical scroll until hitting the bottom, at which point native horizontal scroll took over.Changes
src/components/scroll/revogr-viewport-scroll.tsxshiftKey?: booleantoLocalScrollEventonVerticalMouseWheel: bail out early whenshiftKeyis set — let the horizontal handler own itonHorizontalMouseWheel: computeeffectiveDeltafromdeltaXif available, otherwise fall back todeltaYwhenshiftKeyis helde2e/scroll.spec.ts(new)scrollLeftand leavesscrollTopunchangedscrollTopand leavesscrollLeftunchanged