Hover, segmentation and pan/zoom support for rr.Tensor#12331
Draft
dangom wants to merge 6 commits intorerun-io:mainfrom
Draft
Hover, segmentation and pan/zoom support for rr.Tensor#12331dangom wants to merge 6 commits intorerun-io:mainfrom
dangom wants to merge 6 commits intorerun-io:mainfrom
Conversation
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
Member
|
@dangom thanks for sharing this and kindly providing the context how you got there! You're right we're a bit tight on bandwidth now, the Tensor view in particular hasn't been a priority. I'm also unsure how we want to design mixing in annotation masks in the tensor view 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What
This PR introduces quality of life improvements to rr.Tensor that have been requested multiple times.
Note that I do not know much rust, so a lot of this code was crafted with help from agents. I understand that the maintainers are busy and have little bandwidth to review, but I figured I'd open this PR since the features are working, and if someone with better knowledge wants to take this on or do some testing so these features can make it into main, they might as well have a starting point.
Some things that would have to be done before merging are probably documentation and fallback cases. Currently the segmentation will not show without an AnnotationContext, which can be confusing. The hover UI could also be cleaned up a bit.
Summary
In the screenshot below, note the hover UI and the controllable opacity for the segmentation overlay.

Here an MWE: