You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I add the shortcut "ALT+q"
When you press shortcut this open iframe below the word or above if iframe have no enough space
I thing make option panel for shortcut in a future version, but I don't understand how it work, at the moment
PS: this is my first pull request, if I do something wrong, just tell me :)
Thank you very much for this PR, this is a feature I appreciate to add since a long time.
Unfortunately, I don't have time for now to give you a decent feedback
I'll get back in some months (before next summer I hope).
Do not hesitate in keep this PR updated and/or make new ones.
Thanks to move URLs to HTTPS. I hope this can fix some other reported issues.
I just have some questions about...
... UX:
Why Alt+Q?
Why do'nt use borders nor shadow to separate the translation box from website?
... structure:
What is your intention when declaring web_accessible_resources?
Do you have an idea in how to not repeat the pairUrl variable into popup/script.js and popup/contentScript.js?
Do you have any reason to keep all files into popup/ folder? (ie.: popup/contentScript.js instead of content-scripts/script.js, and popup/background.js instead of background.js)?
Note: I forget to put .editorconfig file, it was my fault, I'll handle it after
I had selected Alt+Q completely random... but also because this key is easy to touch but if want to change go ahead :)
Yes this is a good idea, but the border is printed before the content this is not good... and I don't know how print the content and if the content is loaded add border
Structure:
I add this for export frame.html and add to web page, but It work well without, I remove it
Unfortunately not, I search how to fix this but I don't find a solution at the moment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request answer to issue #5
I add the shortcut "ALT+q"
When you press shortcut this open iframe below the word or above if iframe have no enough space
I thing make option panel for shortcut in a future version, but I don't understand how it work, at the moment
PS: this is my first pull request, if I do something wrong, just tell me :)