feat(json-logic): apply computed attrs on nested allOf/anyOf/oneOf properties#227
Merged
feat(json-logic): apply computed attrs on nested allOf/anyOf/oneOf properties#227
Conversation
85b969d to
c6847ae
Compare
sandrina-p
previously approved these changes
Aug 27, 2025
lukad
previously approved these changes
Aug 28, 2025
lukad
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
cycleThroughAttrsAndApplyValuesimplementation onjson-logicwith a more recursive-ish logic so that properties nested onallOf/anyOf/oneOfdefinitions are also parsed whenx-jsf-logic-computedAttrsare resolved.For instance, given the following property:
the
conston the last item of the property'soneOfwill be properly parsed with the computed value.Also fixes the
devversion release script.