Fix some confusing logs around cache flush#714
Draft
rohanpm wants to merge 1 commit intorelease-engineering:masterfrom
Draft
Fix some confusing logs around cache flush#714rohanpm wants to merge 1 commit intorelease-engineering:masterfrom
rohanpm wants to merge 1 commit intorelease-engineering:masterfrom
Conversation
exodus-gw would log "fastpurge is not enabled" even in cases where fastpurge *was* enabled, but the publish object had no URLs relevant for flush. Many publishes created by exodus-migrator fall into this category. Move the conditionals around a bit so that the log messages are more factual in all cases.
Member
|
@crungehottman, should we drop or implement this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exodus-gw would log "fastpurge is not enabled" even in cases where fastpurge was enabled, but the publish object had no URLs relevant for flush. Many publishes created by exodus-migrator fall into this category.
Move the conditionals around a bit so that the log messages are more factual in all cases.