Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
|
I'm using our repo here as a test for https://github.com/ambient-code/agentready |
PR Code Suggestions ✨Latest suggestions up to 817e896
Previous suggestionsSuggestions up to commit d242b79
|
||||||||||||||||||||||
|
Ah, the duplicate things that qodo sees here are red herrings, b/c CLAUDE.md is a symlink to AGENTS.md. There's not really duplication there. |
Add AGENTS.md containing project-specific guidance for AI coding agents, with quick reference commands for testing/linting and architecture overview. CLAUDE.md symlinks to AGENTS.md for compatibility. Also add .agentready to .gitignore. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
d242b79 to
817e896
Compare
webbnh
left a comment
There was a problem hiding this comment.
Looks good. I just have a couple of additional comments.
| - **Purpose**: Enriches JIRA issues with custom field data from GitHub Projects that isn't available in standard GitHub issue events | ||
| - **GraphQL API**: Uses GitHub's GraphQL API to fetch project field values (upstream_issue.py:32-111) | ||
| - **Supported fields**: priority (mapped to JIRA priority) and storypoints (mapped to JIRA story points) | ||
| - **Configuration**: Requires `github_project_number`, `github_project_fields`, and `github_project_fields` in `issue_updates` |
There was a problem hiding this comment.
github_project_number is optional -- it's required only for disambiguation for issues which are referenced by more than one project; however, if specified, only project metadata from the specified project will be used, so if an issue is associated only with another project (e.g., because the configured project has been closed because the team has started using a new project) no project fields will be sync'd. (That is, if a team is going to use this feature, they need to keep it up to date.)
| - **Purpose**: Enriches JIRA issues with custom field data from GitHub Projects that isn't available in standard GitHub issue events | ||
| - **GraphQL API**: Uses GitHub's GraphQL API to fetch project field values (upstream_issue.py:32-111) | ||
| - **Supported fields**: priority (mapped to JIRA priority) and storypoints (mapped to JIRA story points) | ||
| - **Configuration**: Requires `github_project_number`, `github_project_fields`, and `github_project_fields` in `issue_updates` |
There was a problem hiding this comment.
github_project_fields, andgithub_project_fieldsinissue_updates
The repetition of "github_project_fields" is potentially confusing. Perhaps something like
the
github_project_fieldsconfiguration key and the"github_project_fields"entry in theissue_updateskey.
(Note the quotes around the entry, as distinguishing from the keys.)
There was a problem hiding this comment.
Qodo concurs (and has a more concise suggestion for fixing it). It also found a misspelling (in text which you should probably just delete 😄).
|
@qodo-code-review, I don't know if you read these comments, but the duplication between |
User description
Summary
AGENTS.mdcontaining project-specific guidance for AI coding agentsCLAUDE.mdtoAGENTS.mdfor compatibility with Claude Code.agentreadyto.gitignoreDetails
The
AGENTS.mdfile provides:This helps AI agents quickly understand the codebase structure and common development tasks.
🤖 Generated with Claude Code
PR Type
Documentation
Description
Add AGENTS.md with AI agent guidance and architecture overview
Create CLAUDE.md symlink for Claude Code compatibility
Add .agentready to .gitignore for agent-related files
Diagram Walkthrough
File Walkthrough
AGENTS.md
AI agent guidance with commands and architectureAGENTS.md
codebase
flake8/black/isort
descriptions
avoid duplication
CLAUDE.md
Symlink to AGENTS.md for Claude CodeCLAUDE.md
.gitignore
Add .agentready to gitignore.gitignore