Draft
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| # gem_path = File.expand_path "..", __dir__ | ||
| # grammars_path = File.join gem_path, "grammars", "*" | ||
| # grammars = Dir[grammars_path].sort.map { |gp| File.read gp }.join | ||
| Digest::MD5.hexdigest Relaton::Itu::VERSION + Relaton::Bib::VERSION # grammars |
| module Itu | ||
| class ApprovalStage < Lutaml::Model::Serializable | ||
| attribute :process, :string, values: %w[tap aap] | ||
| attribute :content, :string, values: %w[determined in-force a lc ac lj aj na ar ri at sg c tap] |
| TYPES = %w[ | ||
| recommendation recommendation-supplement recommendation-amendment recommendation-corrigendum | ||
| recommendation-errata recommendation-annex focus-group implementers-guide technical-paper | ||
| technical-report joint-itu-iso-iec resolution service-publication handbook question contribution |
| class Doctype < Bib::Doctype | ||
| TYPES = %w[ | ||
| recommendation recommendation-supplement recommendation-amendment recommendation-corrigendum | ||
| recommendation-errata recommendation-annex focus-group implementers-guide technical-paper |
| module Itu | ||
| class Doctype < Bib::Doctype | ||
| TYPES = %w[ | ||
| recommendation recommendation-supplement recommendation-amendment recommendation-corrigendum |
| module Relaton | ||
| module Itu | ||
| class EditorialGroup < Lutaml::Model::Serializable | ||
| choice(min:1, max:1) do |
|
|
||
| attribute :type, :string, values: %w[ | ||
| tsag study-group focus-group adhoc-group correspondence-group joint-coordination-activity | ||
| working-party working-group rapporteur-group intersector-rapporteur-group regional-group |
| end | ||
|
|
||
| attribute :type, :string, values: %w[ | ||
| tsag study-group focus-group adhoc-group correspondence-group joint-coordination-activity |
Contributor
|
@andrew2net when are you planning to merge this? |
Contributor
Author
|
@ronaldtse it can be merged when all relaton-* gems v2 are ready. We can't use the new gems with old ones together. |
- Implemented DataFetcher class to handle fetching of ITU-R documents from the search API. - Added search_request method for making POST requests and handling pagination. - Updated DataParserR to parse results from the new API structure, including fetching document identifiers, titles, publication dates, and sources. - Enhanced tests for DataFetcher to cover pagination and error handling. - Refactored DataParserR tests to align with the new parsing logic and added cases for different document types. - Created Processor class to manage document processing and fetching.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+105
to
+111
| case value | ||
| when /(\w+),?\s+(\d{4})/ | ||
| month = Date::MONTHNAMES.index($1) | ||
| month ? "#{$2}-#{format('%02d', month)}" : $2 | ||
| when /(\d{4})/ | ||
| $1 | ||
| end |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
…h fetching logic test: add specs for RadioRegulationsParser and RecommendationParser test: implement scraper specs for error handling
…val with search functionality
| private | ||
|
|
||
| def date_from_code(code) | ||
| /(?<cod>.+?)-(?<date>\d{6})(?:-I|$)/ =~ code |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
Encode editorial group data as a contributor entry with role type="author" and description="committee", using Organization with nested Subdivision elements, following the canonical relaton-bib pattern. - Add fetch_workgroup to RecommendationParser to extract study group from the HTML recommendation page (Label8 span) - Add fetch_workgroup stub to RadioRegulationsParser - Split Scraper#fetch_contributors to include editorial contributor with bureau abbreviation and optional study group subdivision - Enable previously-skipped "fetch bureau from code" test - Update fixtures (from_yaml.xml, itu_bib_item.yml, asciibib.adoc) to use contributor-based editorial group format - Regenerate XML fixtures with new editorial contributor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…or Processor class
…in Processor class
…ersion to 2.0.0-alpha.2
…aton-core dependency version
…responding spec issue #85
…ation years issue #86
…n-bib and relaton-core
Each integration test loads and parses index file. This slows down the tests and creates huge VCRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.