Skip to content

Small updates to footer and mobile navbar for web#6492

Merged
carlosabadia merged 2 commits into
mainfrom
carlos/update-footer-and-mobile-navbar
May 12, 2026
Merged

Small updates to footer and mobile navbar for web#6492
carlosabadia merged 2 commits into
mainfrom
carlos/update-footer-and-mobile-navbar

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested a review from a team as a code owner May 12, 2026 12:02
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 12, 2026

Greptile Summary

This PR makes responsive layout improvements to the site footer and marketing navbar for smaller/mobile screen sizes. The footer gets a refactored footer_legal component rendered in two places (desktop and mobile) with appropriate visibility classes, a 2-column mobile link grid, and a simplified newsletter form row; the navbar now shows a shortened "Demo" label on sub-xl viewports instead of hiding the button entirely.

  • footer.py: Extracts footer_legal (dark-mode toggle, copyright, status) into a reusable component shown conditionally per breakpoint; mobile footer links switch from 1-column to 2-column grid; newsletter input is always a row; social icons take full cell height in a persistent border-grid.
  • marketing_navbar.py: "Book a Demo" button now conditionally renders full vs. abbreviated label text instead of toggling visibility of the whole item; "Sign In" item moves to xl:flex hidden; uniform gap-4 replaces the responsive lg:gap-4 gap-2.

Confidence Score: 4/5

Safe to merge — changes are purely CSS class adjustments and a minor component extraction with no logic or state changes.

Both files touch only Tailwind class strings and component composition. The footer extraction of footer_legal is clean; the only nits are a permanently-hidden icon element that adds unused DOM nodes on every footer link, and a set of redundant lg: Tailwind utilities in social_menu_item that are already set by the base class string.

footer.py — the always-hidden chevron icon and redundant lg: classes are worth cleaning up before merge.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/views/footer.py Mobile layout overhaul: responsive grid, extracted footer_legal component, updated newsletter form. Two minor style issues: always-hidden icon and redundant lg: Tailwind classes.
packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py Navbar button responsiveness: "Book a Demo" shows "Demo" on sub-xl screens instead of being hidden; "Sign In" item gets the xl:flex hidden class; uniform gap-4 spacing applied.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[footer_index] --> B[Left Column]
    A --> C[Right Grid]
    A --> D[footer_legal - lg:hidden]

    B --> E[logo]
    B --> F[newsletter]
    B --> G[menu_socials]
    B --> H[footer_legal - max-lg:hidden]

    C --> C1["grid-cols-2 mobile\ngrid-cols-3 desktop"]
    C --> C2[footer_link_flex columns]

    H -->|Desktop only| L1[dark_mode_toggle]
    H --> L2[Copyright]
    H --> L3[server_status]

    D -->|Mobile only| L1
    D --> L2
    D --> L3

    subgraph Navbar
        N1[navigation_menu] --> N2["Sign In xl:flex hidden"]
        N1 --> N3["Book a Demo button"]
        N3 -->|xl and above| N4["Book a Demo text"]
        N3 -->|below xl| N5["Demo text"]
        N1 --> N6["Sidebar toggle xl:hidden"]
    end
Loading

Reviews (1): Last reviewed commit: "Small updates to footer and mobile navba..." | Re-trigger Greptile

Comment thread packages/reflex-site-shared/src/reflex_site_shared/views/footer.py Outdated
Comment thread packages/reflex-site-shared/src/reflex_site_shared/views/footer.py
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 12, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing carlos/update-footer-and-mobile-navbar (4bf0b9e) with main (b76fdc0)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@carlosabadia carlosabadia merged commit a43d523 into main May 12, 2026
69 checks passed
@carlosabadia carlosabadia deleted the carlos/update-footer-and-mobile-navbar branch May 12, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants