Deprecation of image tag vs tags in controller EE definition#256
Closed
j-random-geek wants to merge 5 commits intoredhat-cop:develfrom
Closed
Deprecation of image tag vs tags in controller EE definition#256j-random-geek wants to merge 5 commits intoredhat-cop:develfrom
j-random-geek wants to merge 5 commits intoredhat-cop:develfrom
Conversation
….tags[0] if it exists, then .tag for image tag
…es like a proper string causes an error related to comparison of AnsibleUnicode and float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the deprecation of
tagin the EE definition, anybody using onlytagswill find that the controller EE definition doesn't have a tag specified. This PR arbitrarily chooses the first tag in thetagslist to push to the Controller EE definition. Thetagslist will take precedence overtagif both are defined.It also fixes one ansible-lint complaint, that of a long line in the Pull base image task in
roles/ee_builder/tasks/00_build_ee.yml.Finally, the README was updated to incorporate the
tagvstagsupdate, and also to listee_aap_versionas typefloatrather thanstr, as anybody formatting it as a string (i.e. in quotes) will get an error of a type mismatch on comparison of the string (AnsibleUnicode) to a float, at least with recent versions of ansible-core.How should this be tested?
Create two definitions: one using the (deprecated)
tagand the other using the newtagslist. Build both and push both to Controller by callinginfra.ee_utilities.ee_builderand theninfra.aap_configuration.controller_execution_environmentsin the same play. Both images should appear with the tag specified in Controller.Previously, an image built using
tagswould not have a tag specified in the Controller EE definition.Is there a relevant Issue open for this?
Yes
Other Relevant info, PRs, etc
This is just a suggestion, and I've arbitrarily chosen the first item in the
tagslist as the tag to use in Controller. Please feel free to discard this and create a better solution. I'm not the best at this :)