subscriptions: enable "auto" manageSubscription flag

[Roming22]

tsf-subscriptions handles the "auto" value by listing cluster Subscriptions owned by this Helm release (via lookup and release annotations) and only merging catalog entries whose name is in that set.

This allows subscriptions to not be created when it was installed without the installer.

Assisted-by: Claude

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

[konflux-ci-qe-bot]

@Roming22: The following matrix E2E test has Failed, say /retest to rerun failed tests.

Total child pipelines: 2
Failed child pipelines: 2

Failed child pipelines

PipelineRun Name	Status	Rerun command	Build Log	Test Log
tsf-e2e-4.20-vr6b6	Failed	/retest	View Pipeline Log	View Test Logs
tsf-e2e-4.21-hrtkw	Failed	/retest	View Pipeline Log	View Test Logs

[otaviof]

/retest

[konflux-ci-qe-bot]

@Roming22: The following matrix E2E test has Failed, say /retest to rerun failed tests.

Total child pipelines: 2
Failed child pipelines: 2

Failed child pipelines

PipelineRun Name	Status	Rerun command	Build Log	Test Log
tsf-e2e-4.20-m554m	Failed	/retest	View Pipeline Log	View Test Logs
tsf-e2e-4.21-js5qc	Failed	/retest	View Pipeline Log	View Test Logs

[dperaza4dustbit]

No sure what is the difference between auto and false. I would expect some changes in docs to make that distinction

[Roming22]

@dperaza4dustbit

• true: manage the subscription. Will fail if a subscription not controlled by the tsf-subscription chart already exists.
• false: do not manage the subscription. Will fail if a required subscription has not been deployed manually.
• auto: manage the subscription if it is controlled by the tsf-subscription chart, or if does not exists at all. Do no manage the subscription if it exists and is not controlled by tsf-subscription.

Does that clear it up? I'll ask @gtrivedi88 to update the docs to reflect the change.

In the future, I would hope that it is part of the Helmet "API" for the config.yaml or bundle.yaml, and it should be documented there.

[dperaza4dustbit]

@dperaza4dustbit

• true: manage the subscription. Will fail if a subscription not controlled by the tsf-subscription chart already exists.
• false: do not manage the subscription. Will fail if a required subscription has not been deployed manually.
• auto: manage the subscription if it is controlled by the tsf-subscription chart, or if does not exists at all. Do no manage the subscription if it exists and is not controlled by tsf-subscription.

Does that clear it up? I'll ask @gtrivedi88 to update the docs to reflect the change.

In the future, I would hope that it is part of the Helmet "API" for the config.yaml or bundle.yaml, and it should be documented there.

It does, so why not always do auto then, this change actually remove the need to have an option for this IMO

[Roming22]

It does, so why not always do auto then, this change actually remove the need to have an option for this IMO

Great question! For a couple reasons:

1. I want to give the user control about what's happening if they want to.
2. It turns out some bundles won't support auto. An example is tekton-pipelines. This is because TektonConfig can't be managed by multiple charts.

We could decide to make auto the default for everything though. But for the moment, I prefer to keep it limited to the one operator that causes issues.

[dperaza4dustbit]

Sounds good

[dperaza4dustbit]

/lgtm

[konflux-ci-qe-bot]

@Roming22: The following matrix E2E test has Failed, say /retest to rerun failed tests.

Total child pipelines: 2
Failed child pipelines: 2

Failed child pipelines

PipelineRun Name	Status	Rerun command	Build Log	Test Log
tsf-e2e-4.20-twwdq	Failed	/retest	View Pipeline Log	View Test Logs
tsf-e2e-4.21-4zxp4	Failed	/retest	View Pipeline Log	View Test Logs

[Roming22]

/retest

[konflux-ci-qe-bot]

@Roming22: The following matrix E2E test has Failed, say /retest to rerun failed tests.

Total child pipelines: 2
Failed child pipelines: 2

Failed child pipelines

PipelineRun Name	Status	Rerun command	Build Log	Test Log
tsf-e2e-4.20-bwb2f	Failed	/retest	View Pipeline Log	View Test Logs
tsf-e2e-4.21-d5hlz	Failed	/retest	View Pipeline Log	View Test Logs

[konflux-ci-qe-bot]

@Roming22: The following matrix E2E test has Failed, say /retest to rerun failed tests.

Total child pipelines: 2
Failed child pipelines: 2

Failed child pipelines

PipelineRun Name	Status	Rerun command	Build Log	Test Log
tsf-e2e-4.20-nlz62	Failed	/retest	View Pipeline Log	View Test Logs
tsf-e2e-4.21-9qs8w	Failed	/retest	View Pipeline Log	View Test Logs