Open
Conversation
Contributor
ckhordiasma
commented
Mar 16, 2026
ckhordiasma
commented
- define params-file param, and params-init step
- change params-init step base image
Contributor
Author
|
/retest |
…line Correct Tekton variable syntax for params-init task results (use $(tasks.params-init.results.<name>) instead of $(results.params-init.<name>) and $(tasks.params-init.<name>)) and quote variable in tee command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace duplicate yq invocation (check then read) with a single call that captures the value and handles the missing-param case inline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…init Move $(params.*) substitutions from inline script into env blocks so values are not subject to shell interpretation. Consolidate parallel arrays into a single PARAM_NAMES list with env var names derived by convention (PARAM_<UPPER_SNAKE>). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Derive param values from env vars using bash indirection (${!ENV_NAME})
based on a naming convention (PARAM_<UPPER_SNAKE>), eliminating the
parallel PARAM_VALUES array. Result paths remain hardcoded since Tekton
validates $(results.*) references at admission time.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…esult paths" This reverts commit 26aeb8b.
… params-init" This reverts commit f729674.
Replace the no-op base image directive with a multi-stage build that compiles a simple Go program on ubi9/go-toolset and runs it on ubi9/ubi-minimal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yq -e treats YAML boolean false as falsy and exits with code 1, even
when the field exists. Use has("value") to check field existence
separately, then read the value without -e.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a header line, indent each param, and print values on labeled lines instead of concatenating them via tee. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Detect the YAML value type and output compact JSON for arrays (!!seq) and objects (!!map) to match Tekton's expected result format. Scalar values continue to be written as plain text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add PARAM_TYPES array to distinguish string/array/object params. Array params are serialized to JSON via jq in PARAM_VALUES. The override loop already handles type-aware output. Downstream references updated to use params-init results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace bash script with Python for cleaner param handling. Uses yq to convert the YAML params file to JSON, then reads it with json.load(). Type detection for array/object results is handled natively via isinstance() instead of yq type checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace hardcoded PARAMS dict with argparse (--name, --path, --value). All param defaults are now passed through Tekton args, avoiding inline substitution in the script. Type is inferred from value count: multiple values = array, single = string. Adding a new param only requires a new args line and a taskSpec result entry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Expand comma-separated args into individual block sequence entries. YAML block style requires each item on its own '- ' line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use --array before --value to indicate the param is an array type, ensuring single-element arrays are serialized as JSON arrays rather than plain strings. Replace argparse with manual arg parsing to keep flag grouping per param. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New string params: prefetch-mode, prefetch-config-file-content, prefetch-log-level, fetch-git-tags, clone-depth, additional-build-secret, rhel-subscription-activation-key, path-context, dockerfile. New array params: build-args, additional-labels. All downstream references updated to use params-init task results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
See if Tekton allows array pipeline params with [*] in inline taskSpec args without explicit task-level param declarations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.