Skip to content

Improve AssertCompareOnCountableWithMethodToAssertCountRector #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Dec 23, 2024
Merged

Improve AssertCompareOnCountableWithMethodToAssertCountRector #424

TomasVotruba merged 1 commit into from
Dec 23, 2024

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Dec 23, 2024

Previously

  • It supported only assertEquals/assertSame
  • It supported only count function

Now

  • It also supports assertNotEquals/assertNotSame
  • It also supports sizeof and iterator_count functions

@VincentLanglet VincentLanglet force-pushed the improveCompareOnCountable branch from 4d126c7 to 1826fb4 Compare December 23, 2024 09:41
@VincentLanglet VincentLanglet marked this pull request as ready for review December 23, 2024 09:42
@VincentLanglet VincentLanglet mentioned this pull request Dec 23, 2024
Closed
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 23, 2024

Thank you for the improvements 🥳

@TomasVotruba TomasVotruba merged commit c7ac374 into rectorphp:main Dec 23, 2024
6 checks passed
@TomasVotruba TomasVotruba mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VincentLanglet @TomasVotruba