Skip to content

Dockerize commands for the dotnet namespace#77

Merged
andre-vidal merged 11 commits intodevelopmentfrom
dockerize-dotnet-commands
Jan 6, 2024
Merged

Dockerize commands for the dotnet namespace#77
andre-vidal merged 11 commits intodevelopmentfrom
dockerize-dotnet-commands

Conversation

@Davane
Copy link
Contributor

@Davane Davane commented Dec 1, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This pull request aims to containerize the dotnet commands so that docker is the only dependency that you will need when working with Frontier created dotnet project. The following features were also added:

  • Ability to include sentry or not using flags when creating the project.
  • Hot reloading when changes are made within the project.
  • Ability to specify the environment when running migration commands using flags.
  • Ability to specify the configuration when running migration commands using flags (Debug or release).
  • (Experimental) Added the ability to remove applied migrations from the DB.
  • (Experimental) Ability to specify the Dotnet SDK version (Docker Image) to use and create the project.

Caveat

  • A side effect of the hot reload feature is that when migrations are created the hot reload functionality will pick this up as a change within the project and automatically apply the migration to the DB.
  • Starting up the project for the first time will cause errors related to the unapplied migrations but once you create the initial migration and start the project again then the errors will be gone. This might be related to the the fact that the project is trying to applied existing migrations during startup but because no DB exists it is failing.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly

@Davane Davane self-assigned this Dec 1, 2023
@Davane Davane changed the title (WIP) Dockerize commands for the dotnet namespace Dockerize commands for the dotnet namespace Dec 7, 2023
Copy link
Contributor Author

@Davane Davane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marlonajgayle & @andre-vidal Can you review when you get a chance?

There are also changes in the dotnet template as well marlonajgayle/dotnet-web-api-template#33

@andre-vidal andre-vidal merged commit 73118fb into development Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants