fix: resolve RecursionError when activator is in same provider as its marker (#689)#691
Open
fadedDexofan wants to merge 1 commit intoreagento:developfrom
Open
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
fadedDexofan
force-pushed
the
fix/689-recursion-provider-level-activation
branch
5 times, most recently
from
e170371 to
bed8cfd
Compare
… marker (reagento#689) Activators should not inherit when conditions from the provider, as they are the source of marker activation, not consumers. Reset when_active and when_override to None in Activator.__get__().
fadedDexofan
force-pushed
the
fix/689-recursion-provider-level-activation
branch
from
bed8cfd to
1d326bc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #689
when_active/when_overrideconditions from the provider'swhen, as they are the source of marker activation, not consumers, so we reset both toNoneinActivator.__get__()afterFactory.__get__()applies the provider-levelwhen.