Fix #301, make equation numbers appear on the right#1549
Open
eebasso wants to merge 4 commits intoreadthedocs:masterfrom
Open
Fix #301, make equation numbers appear on the right#1549eebasso wants to merge 4 commits intoreadthedocs:masterfrom
eebasso wants to merge 4 commits intoreadthedocs:masterfrom
Conversation
Author
|
I did find one way to obtain the vertical alignment of the equation numbers using a Y translation trick of but this lead to the header links disappearing and the equation numbers overlapping the formulas for sufficiently narrow viewing windows. Therefore, I decided against adding this to the PR. |
Author
|
Please let them merge this. The equation numbering default is just comically bad at this point. |
|
I also support the merging of this fix. The equation numbering is the only bad feature I found in the rtd-theme. But if not fixed I will need to change for another theme, even if I think that this theme is perfect on all other points. |
… fix-equation-numbering
…d_theme into fix-equation-numbering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Modify the MathJax SASS file to have equation numbers appear to the right of displayed formulas. This resolves the long-standing issue #301 while still having the header links appear, which improves upon the solution given by #301 (comment) . These changes also avoid the use of any margin manipulations, which can lead to odd behavior when hovering vs not.
An unresolved issue is the vertical alignment of the equation numbers relative to the displayed formulas. This PR leads to an upper alignment, but a middle alignment seems preferable to most users. Hopefully, PR #383 can follow up on this and resolve the vertical alignment problem.
Regardless, I think these changes are a strict improvement over the status-quo.
Edit: this just comes directly from the Sphinx basic theme. It shouldn't take 7+ years to figure this out!