Fix replay history size validation#4306
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
marked this pull request as ready for review
July 2, 2026 04:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid replay history sizes and replay-all batch sizes are now rejected up front with
IllegalArgumentException, rather than allowing low-level arithmetic or array-size failures to surface from replay buffer internals.This validates the shared replay processor creation path for invalid
historySizevalues, and validatesSinks.many().replay().all(int)/Sinks.unsafe().many().replay().all(int)batch sizes before constructing the underlying replay buffers. Existing behavior for valid arguments is unchanged; invalid arguments now fail earlier and consistently withIllegalArgumentException, includingInteger.MAX_VALUEvalues that would overflow replay linked-array sizing.Fixes #4274.
Testing:
./gradlew :reactor-core:test --tests reactor.core.publisher.SinksTest --tests reactor.core.publisher.SinkManyReplayProcessorTest spotlessCheck -PspotlessFrom=origin/main --no-daemon./gradlew check -PspotlessFrom=origin/main --no-daemongit diff --check origin/main...HEADBreaking changes: None for valid inputs.