[rlsw] Remove position attribute from sw_vertex_t#5677
Merged
raysan5 merged 3 commits intoraysan5:masterfrom Mar 20, 2026
Merged
[rlsw] Remove position attribute from sw_vertex_t#5677raysan5 merged 3 commits intoraysan5:masterfrom
sw_vertex_t#5677raysan5 merged 3 commits intoraysan5:masterfrom
Conversation
sw_vertex_tsw_vertex_t
Contributor
Author
|
I also just fixed a bug with By the way, the push/pop functions could be easily simplified, but hey |
Owner
|
@Bigfoot71 thanks for the review!
I imagine you mean on rlgl side, that system was implemented ~10 years ago and probably it can be improved |
Contributor
Author
No I did mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just replace
float coord[4]withfloat position[4]instead.Until now the world position was being preserved, but the only real point would be if we ever add lighting as defined in OpenGL 1.1, and therefore also at the rlgl level, but that doesn't seem to be planned.
By the way, positions were interpolated during clipping, so this should produce a marginal gain at this stage.