[RayService][Bug] applyServeTargetCapacity: accept int64/float64 for cached target_capacity (#4777)

[SAY-5]

Closes #4777.

Why

applyServeTargetCapacity reads the cached ServeConfigV2 string,
unmarshals it with k8s.io/apimachinery/util/yaml, and asserts
serveConfig["target_capacity"].(float64) so it can skip
UpdateDeployments when the cached value already matches the goal.

util/yaml decodes plain integer scalars as int64 (it routes
JSON-compatible input through encoding/json with UseNumber off,
and gopkg.in/yaml.v2 also returns int64 for integer scalars). The
float64 assertion therefore always failed for any
target_capacity written as a plain integer, the idempotency branch
was always skipped, and the controller called UpdateDeployments on
every reconcile even when the value was already current.

The existing TestReconcileServeTargetCapacity didn't catch this
because every case used a cached/goal mismatch (0 → 30 / 60 → 30
etc.), so the controller proceeded to the update branch in both the
intended-skip and intended-update flows — masking the bug entirely.

Fix

• New targetCapacityAsInt32(any) (int32, bool) helper that accepts
  int64, float64, int, and int32, returning int32. Rejects
  nil / string / map / other types.
• applyServeTargetCapacity now uses the helper for the idempotency
  check.

Tests

ray-operator/controllers/ray/rayservice_controller_unit_test.go:

• TestApplyServeTargetCapacity_SkipsUpdateWhenCachedMatchesGoal
  — the cached/goal scenario the previous suite never covered. Cached
  ServeConfigV2 = '{"target_capacity": 60}' and goal 60 must NOT
  call UpdateDeployments. Asserts fakeDashboard.LastUpdatedConfig
  stays empty.
• TestTargetCapacityAsInt32 — 7 sub-cases covering int64,
  float64, int, int32, nil, string, map.
• The existing TestReconcileServeTargetCapacity still passes
  unchanged.

Verification

• go test ./controllers/ray/ -run "TestApplyServeTargetCapacity_SkipsUpdateWhenCachedMatchesGoal|TestTargetCapacityAsInt32|TestReconcileServeTargetCapacity" → all green.
• I confirmed locally that reverting just the controller change
  while keeping the test makes the new
  TestApplyServeTargetCapacity_SkipsUpdateWhenCachedMatchesGoal
  fail with Should be empty, but was [123 34 116 97 ... 54 48 125]
  — the byte representation of {"target_capacity":60} that
  UpdateDeployments should never have been called with — i.e. the
  test catches the regression.

[chenshi5012]

LGTM , FIX so quickly

[Future-Outlier]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[JiangJiaWei1103]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 9341b20. Configure here.}

[SAY-5]

Pushed an update that addresses the gosec G115 lint failures from the previous CI run. The two flagged conversions in targetCapacityAsInt32 (rayservice_controller.go:1414, :1418) used unconditional int32(n) casts; gosec's concern was that an int64 / int payload from a YAML / JSON document could overflow.

Now targetCapacityAsInt32 range-checks against math.MinInt32 / math.MaxInt32 (and rejects NaN / Inf for float64) before the conversion, returning ok=false on out-of-range values rather than silently truncating. The target_capacity semantic is 0–100 in practice, so any out-of-range value is malformed input that should fall through to the existing "unsupported value" log path instead of a garbage int32 hitting the dashboard.

Test TestTargetCapacityAsInt32 gains seven new cases pinning the rejection of int64/int/float64 above MaxInt32, below MinInt32, and the float64 special values NaN / +Inf / -Inf. The original 7 cases remain. Local go test -run TestTargetCapacityAsInt32 is 14/14 green; go vet ./... and go build ./... are both clean.

Also rebased onto current master to clear the staleness.