Remove Doctrine annotations in favor of PHP 8 attributes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR migrates from Doctrine annotations to PHP 8 attributes, upgrades core dependencies for PHP 8 compatibility, and modernizes testing and CI configurations. Class diagram for updated annotation classes using PHP 8 attributesclassDiagram
class Cookie {
<<final>>
+__construct()
}
class DeleteCookie {
<<final>>
+__construct()
}
class Qualifier
Cookie --|> Qualifier
DeleteCookie --|> Qualifier
Cookie : <<Attribute>>
DeleteCookie : <<Attribute>>
Class diagram for AuraSessionInject trait after annotation removalclassDiagram
class AuraSessionInject {
-Session session
+setSession(Session session)
}
class Session
AuraSessionInject --> Session
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
WalkthroughThe PR modernizes the codebase for PHP 8+ by replacing Doctrine-style PHPDoc annotations with native PHP 8 attributes in annotation classes, updating minimum PHP requirement from 7.2 to 8.0, bumping dependencies (Ray.Di, PHPUnit), and updating CI/test configuration to PHPUnit 9.6 standards. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider specifying attribute targets on your PHP 8 attributes (e.g. Attribute::TARGET_CLASS or TARGET_METHOD) to match the original Doctrine annotation usage and prevent unintended placements.
- Update any usage examples or README content that reference Doctrine annotations so they illustrate the new PHP 8 attribute syntax and guide users through the migration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider specifying attribute targets on your PHP 8 attributes (e.g. Attribute::TARGET_CLASS or TARGET_METHOD) to match the original Doctrine annotation usage and prevent unintended placements.
- Update any usage examples or README content that reference Doctrine annotations so they illustrate the new PHP 8 attribute syntax and guide users through the migration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
Summary by Sourcery
Remove legacy Doctrine annotations in favor of native PHP 8 attributes, bump PHP requirements and dependencies for PHP 8 compatibility, and modernize the testing and CI configuration.
Enhancements:
Build:
CI:
Tests:
Chores:
Summary by CodeRabbit
Chores
Refactor