Use 1D grid calculations in epsilon_neighborhood#1847
Use 1D grid calculations in epsilon_neighborhood#1847rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
epsilon_neighborhood#1847Conversation
dantegd
left a comment
There was a problem hiding this comment.
Looks good to me, though before approving explicitly wanted to ask if you think it'd be worth adding a explicit test to exercise this?
@dantegd good idea. Will add 👍 |
tarang-jain
left a comment
There was a problem hiding this comment.
I see what is being done here. LGTM except possibly one minor optimization
viclafargue
left a comment
There was a problem hiding this comment.
Thanks Divye! LGTM. An alternative solution would have been to swap the x and y dimensions. The number of features divided by Policy::Mblk should rarely ever go beyond the limit of 65535. This would avoid adding an argument to the kernel and also avoid the two small instructions to get block_x and block_y back. But, I agree that the current solution may be more robust.
|
@viclafargue That solution does not work because we cannot guarantee always that |
|
/merge |
Closes rapidsai/cuml#5393 closes rapidsai/cuml#7676
This was necessary to bypass the limits of
grid.y < 65536, as cuml passesn_rowsto then_colsdimension in the usage of this API.