Fix doctest parametrization for pytest 9.1#5561
Merged
Merged
Conversation
Signed-off-by: rlratzel <rratzel@nvidia.com>
19d97a7 to
6945439
Compare
alexbarghi-nv
approved these changes
Jun 22, 2026
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest.mark.parametrize.Details
Pytest 9.1 deprecated passing non-
Collectioniterables, such as generators and iterators, asargvaluestopytest.mark.parametrize/metafunc.parametrize.The pytest docs recommend converting generators and iterators to a
listortuplebecause they can otherwise be exhausted after one collection pass.This repo also promotes
DeprecationWarningto errors inpython/cugraph/pytest.ini, so the new pytest warning can fail collection in pytest 9.1.x.The doctest set is small, so eagerly materializing it is cheap and matches pytest's documented migration path.
References:
Testing
git diff --check upstream/main..HEADdocker exec 8cf097001d69 python -m pytest /Projects/cugraph/python/cugraph/cugraph/tests/docs/test_doctests.py --collect-only -qFull doctest execution was also attempted in the provided container and failed due to missing local dataset files, for example
karate.csv, unrelated to this collection-time change.